https://bugzilla.redhat.com/show_bug.cgi?id=187318 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #69 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Use %global not %define %global srcname mondo - Group: is not used by Fedora - Not needed: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -u -n) - Please justify this, why wouldn't it be available on all Fedora supported arches: ExclusiveArch: x86_64 i586 i386 i686 ia64 (also use %{ix86} instead of i586 i386 i686 - make %{?_smp_mflags} → %make_build - Not needed : rm -rf $RPM_BUILD_ROOT %clean rm -rf $RPM_BUILD_ROOT - make DESTDIR=$RPM_BUILD_ROOT install → %make_install - Not needed it is the default: %defattr(-,root,root) - The license file COPYING must be installed with %license not %doc %license COPYING - I can't find: ftp://ftp.mondorescue.org/test/src/mondo-3.3.0.0.20201118013837.tar.gz I'd rather use http://www.mondorescue.org/ftp/src/ - The release is weird: Release: 0.20201118013837.s3776M%{dist} It should start at 1 for a release. Why are 20201118013837 and s3776M needed? Is it extra versioning info? -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
