https://bugzilla.redhat.com/show_bug.cgi?id=1918111 Stephen Gallagher <sgallagh@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |sgallagh@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |sgallagh@xxxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |needinfo?(michel@michel-slm | |.name) --- Comment #1 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- warning: Explicit %attr() mode not applicable to symlink: /builddir/build/BUILDROOT/bitwarden-cli-1.13.3-1.fc34.x86_64/usr/bin/bw I think you can just drop that, since you set the permissions of the linked file in the %install section. Also please include a comment explaining how you generated the bundled dependencies and licenses. Other than that, it looks good to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
