https://bugzilla.redhat.com/show_bug.cgi?id=1917271 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- > %global rpm_macros_dir %(d=%{_rpmconfigdir}/macros.d; [ -d $d ] || d=%{_sysconfdir}/rpm; echo $d) This is irrelevant, we can just use %_rpmmacrodir, as that's defined in RHEL8 and newer, and backported to EPEL7. > %if 0%{?rhel} < 9 > %ifarch %{ix86} > %global no_sse2 1 > %endif > %endif This conditional is wrong. Fedora 29 updated the i686 baseline to include SSE2: https://fedoraproject.org/wiki/Changes/Update_i686_architectural_baseline_to_include_SSE2 This should be "%if 0%{?rhel} && 0%{?rhel} < 9". > BuildRequires: clang >= 3.7.0 I'm pretty sure this is wrong, since Qt6 requires a C++17 compiler. > %if 0%{?fedora} || 0%{?rhel} > 6 There's a bunch of these that can just be ripped out. > %if 0%{?fedora} > 22 This can be dropped as well. > %setup -q -n %{qt_module}-everywhere-src-%{version} > > # omit '-b .tell-truth-about-private-api' so it doesn't end up in installed files -- rdieter > %patch1 -p1 > > # Upstreamable patches > %patch50 -p1 -b .version-check > %patch51 -p1 -b .moc-macros > %patch52 -p1 -b .qmake-lflags > %patch53 -p1 -b .no-relocatable > %patch54 -p1 -b .cxxflag.patch > %patch55 -p1 -b .firebird > %patch56 -p1 -b .mysql > # omit -b .python3 > %patch57 -p1 > > %patch80 -p1 -b .use-wayland-on-gnome.patch > > %patch90 -p1 -b .gcc11 Please just use "%autosetup -n %{qt_module}-everywhere-src-%{version} -p1" > Name: Qt6 > Description: Qt6 Configuration > Version: 6.0.0 This should probably use "Version: %{version}" for the generated pkgconfig file... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
