https://bugzilla.redhat.com/show_bug.cgi?id=1917128 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominik@xxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- > BuildRequires: gnu-efi-devel gcc openssl openssl-devel sbsigntools perl-File-Slurp help2man Please put one dependency per line and sort alphabetically. It takes a bit more space but makes future diffs much more readable. > Requires: parted mtools util-linux coreutils As above. By the way, shouldn't it have Recommends: sbsigntools? Is it even functional without sbsigntools installed? > %install > %make_install > > rm -f %{buildroot}/%{_datadir}/efitools/COPYING > rm -f %{buildroot}/%{_datadir}/efitools/README Please use rm -v instead. rm -f won't fail if these files are no longer there, so you won't notice you don't need it anymore. > %files ... > %dir %{_datadir}/efitools > %dir %{_datadir}/efitools/efi > %{_datadir}/efitools/efi/* Unless you want to list every file under %{_datadir}/efitools/efi/, you should simply use: %{_datadir}/efitools -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
