https://bugzilla.redhat.com/show_bug.cgi?id=1917089 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > # set upstream name variable > %global srcname doubleratchet That define is used in exactly one place. I think you might as well drop it and save three lines and a little bit of obfuscation. Maybe add this to the package description, so it's easier to guess what the package is about: > A double ratchet allows message encryption providing perfect forward secrecy. A double ratchet instance synchronizes with a second instance using Diffie-Hellman calculations, that are provided by the DHRatchet class. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx