[Bug 1916936] Review Request: libdispatch - Apple's Grand Central Dispatch library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1916936



--- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> ---
> %global debug_package %{nil}

Why are you doing this?

> Provides:       %{name} = %{version}-%{release}

This is redundant, as RPM autogenerates this already.

> cmake -G Ninja -DCMAKE_INSTALL_PREFIX=%{buildroot}%{_usr} -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ .
> ninja
> [..]
> ninja install


Why isn't this using the CMake macros, like so?

> %cmake -G Ninja
> %cmake_build
> [..]
> %cmake_install

> %post -p /sbin/ldconfig
> %postun -p /sbin/ldconfig

This is unneeded for EPEL8+ and Fedora. If you need EPEL7 compatibility, use
"%ldconfig_scriptlets" instead:
https://fedoraproject.org/wiki/EPEL:Packaging#Shared_Libraries


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux