https://bugzilla.redhat.com/show_bug.cgi?id=1916648 code@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(guido.aulisi@gmai | |l.com) --- Comment #3 from code@xxxxxxxxxxxxxxxxxx --- So the issues I found were mostly a matter of excessive macro complexity. I think there is no need to try to be compatible with situations that do not occur in supported Fedora releases or in EPEL8. Otherwise, this seems to be a nice, clean package. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== [!]: The %python_provide macro is obsolete, and should not be used on Fedora. Its replacement, %py_provides, is only needed on Fedora 32, at least for python3-* packages. To remind yourself to remove the latter when no longer needed, I recommend the following if you want to build for F32-F34 and EPEL8: %if 0%{?epel} && 0%{?epel} <= 8 %{?python_provide:%python_provide python%{python3_pkgversion}-%{pypi_name}} %elif 0%{?fedora} == 32 %py_provides python3-%{pypi_name} %endif See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro. [!]: %{?!python3_pkgversion:%global python3_pkgversion 3} is not needed; it will already be defined in EPEL7 as “36” and in EPEL8 and Fedora as “3”. See (non-authoritative) https://fedoraproject.org/wiki/PackagingDrafts:Python3EPEL. [!]: %{?python_enable_dependency_generator} does not really do anything. The dependency generator is enabled by default on all supported Fedoras and EPEL8, and not available on EPEL7. [!]: Since you are not targeting EPEL7, the conditional manual Requires are not needed either. [?]: There is no rule against repeating yourself, but a common pattern is: %global common_description %{expand: Lots of text goes here and here.} %description %{common_description} # (later in the spec file) %description -n python%{python3_pkgversion}-%{pypi_name} \ %{common_description} You don’t have to do that, but it does tidy up the spec file a bit. [?]: Please consider the following simplification: URL: https://gitlab.com/lv2/%{pypi_name} Source0: %{url}/-/archive/v%{version}/%{pypi_name}-v%{version}.tar.bz2 ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* ISC License". 16 files have unknown license. Detailed output of licensecheck in /home/ben/src/fedora/reviews/python-sphinx_lv2_theme/1916648-python- sphinx_lv2_theme/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. No compiled or minified CSS or JavaScript may be included, unless it is created from the original sources as part of the RPM build and the original sources are included; see https://docs.fedoraproject.org/en-US/packaging-guidelines/Web_Assets/#_css and https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/. The good news is, this package has no JavaScript and uses simple, hand-written CSS, so there is no problem. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://gitlab.com/lv2/sphinx_lv2_theme/-/archive/v1.0.0/sphinx_lv2_theme-v1.0.0.tar.bz2 See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments This is bogus; the URL is fine. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Upstream tarball lacks tests. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-sphinx_lv2_theme-1.0.0-1.fc34.noarch.rpm python-sphinx_lv2_theme-1.0.0-1.fc34.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- python3-sphinx_lv2_theme (rpmlib, GLIBC filtered): python(abi) python3.9dist(sphinx) Provides -------- python3-sphinx_lv2_theme: python-sphinx_lv2_theme python3-sphinx_lv2_theme python3.9-sphinx_lv2_theme python3.9dist(sphinx-lv2-theme) python3dist(sphinx-lv2-theme) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1916648 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: Java, Ocaml, Perl, Haskell, C/C++, PHP, fonts, R, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
