https://bugzilla.redhat.com/show_bug.cgi?id=1914638 code@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra |needinfo?(mikel@olasagasti. |in.net) |info) --- Comment #6 from code@xxxxxxxxxxxxxxxxxx --- Normally, one of the SHOULD points in a review is “%check is present and all tests pass.” The upstream tarball *does* have tests, but they all require privilege (sudo). I’d just like to see a comment where the %check section would be, explaining that this is why there is no %check section, so the reason is clear to anyone reading the spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
