https://bugzilla.redhat.com/show_bug.cgi?id=1912335 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Some drive-by comments (Neal, I hope you don't mind): - The comment at the top of the .spec file is confusing, and I assume it's no longer accurate, since the .spec file is now using the standard way to use git snapshots from GitLab. - The snapshot versioning isn't quite correct yet: The version "1.20.99" does not exist upstream (yet?), so either use the latest stable version as base Version (1.20.10) and use post-release-snapshot versioning (Release "1.%{gitdate}git%{shortcommit}%{?dist}"). Or, if "1.20.99" *would* be the next expected version, then use "1.20.99" as base Version and use pre-release-snapshot versioning (Release "0.1.%{gitdate}git%{shortcommit}%{?dist}", note the leading "0.", which differentiates pre-release snapshots from post-release-snapshots). - The history of version/release values in the changelog entries are revealing another snapshot versioning issue: Since the Version field does not change when bumping to a new commit or doing packaging-only changes, the first non-zero digit of "Release" must be incremented by 1 each time (this is what "rpmdev-bumpspec" automatically does for you), and only reset to "1" if the Version field actually changes (or set to "0" and then using rpmdev-bumpspec to bump it to 1 and add a %changelog entry for the new version). Now, I think you can just drop all those changelog entries when importing the package into fedora, but going forward, you should not keep a Release of "1" when the "Version" is unchanged, because that's the wrong way to do versioning in this case. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
