https://bugzilla.redhat.com/show_bug.cgi?id=1912335 --- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> --- > #VCS: git:git://git.freedesktop.org/git/xorg/xserver > %if 0%{?gitdate} > # git snapshot. to recreate, run: > # ./make-git-snapshot.sh `cat commitid` > Source0: xorg-server-%{gitdate}.tar.xz > Source1: make-git-snapshot.sh > Source2: commitid > %else > Source0: https://www.x.org/pub/individual/xserver/%{pkgname}-%{version}.tar.bz2 > Source1: gitignore > %endif This entire strategy is wrong. The source code for the X server software is hosted on a GitLab instance[1], so you can follow the standard guidelines for snapshot packaging[2]. [1]: https://gitlab.freedesktop.org/xorg/xserver [2]: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_hosting_services > Version: 1.20.99 > Release: 1%{?gitdate:.%{gitdate}}%{?dist} Please use proper snapshot versioning: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots > BuildRequires: pkgconfig(xcb-aux) pkgconfig(xcb-image) pkgconfig(xcb-icccm) > BuildRequires: pkgconfig(xcb-keysyms) pkgconfig(xcb-renderutil) Please reformat these to be one BR per line, so that it's easily diffable. > %prep > %autosetup -N -n %{pkgname}-%{?gitdate:%{gitdate}}%{!?gitdate:%{version}} > rm -rf .git > cp %{SOURCE1} .gitignore > # ick > %global __scm git > %{expand:%__scm_setup_git -q} > %autopatch Just change this to "%autosetup -S git_am %{?gitdate:-n xserver-%{commit}}" > Obsoletes: Xwayland < %{version}-%{release} > [...] > Obsoletes: Xwayland-devel < %{version}-%{release} These packages do not exist in Fedora, so this doesn't need to be present. > # X.org requires lazy relocations to work. > %undefine _hardened_build > %undefine _strict_symbol_defs_build > [...] > export CFLAGS="$RPM_OPT_FLAGS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1" > export CXXFLAGS="$RPM_OPT_FLAGS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1" > export LDFLAGS="$RPM_LD_FLAGS -specs=/usr/lib/rpm/redhat/redhat-hardened-ld" This seems to be the wrong way to enable lazy relocations, per the build flags documentation[3]. Please take a look and see if the guidance provided there works. [3]: https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md#lazy-binding -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
