https://bugzilla.redhat.com/show_bug.cgi?id=1900145 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@xxxxxxxxxx --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- The Url value works, but the server redirects to <http://trac.project-builder.org/>. Please add the trailing slash to the Url value in the spec file. Source value does not work. The spec file links to <ftp://ftp.project-builder.org/test/src/ProjectBuilder-0.16.2.0.20201118030309.tar.gz>, but there is no such file on the server. The only similar file there is ProjectBuilder-0.16.2.0.20210106113635.tar.gz. Please update your spec file the new upstream release. I also recommend you reading Fedora packaging guide lines <https://docs.fedoraproject.org/en-US/packaging-guidelines/> and update your spec file accordingly: Group and BuildRoot tags should not used <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections> Release value must use %{?dist} macro <https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/>. You need to specify all build-time dependencies (perl-interpreter for perl program, make for make, findutils for find, coreutils for rm, and perl(FOO) for any FOO Perl module used from your tests). You should use %{make_build} and %{make_install} macros instead of "make %{?_smp_mflags}" and "make DESTDIR=${RPM_BUILD_ROOT} install". Please see <https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/> and <https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMaker> how to package Perl code in Fedora. You should remove %clean section. You should remove %defattr(-,root,root,-) from %files section. You have to use %license macro for the COPYING file <https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/>. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
