https://bugzilla.redhat.com/show_bug.cgi?id=1912169 code@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from code@xxxxxxxxxxxxxxxxxx --- Looks like a good start. This is not a full review, just a couple of things I noticed at first glance. It looks like the bundled FatFs has a “custom” BSD-like license. Since it is not on https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses, please get an opinion from legal@xxxxxxxxxxxxxxxxxxxxxxx regarding whether it is acceptable and what it should be called. Whatever this license is, it must be added to the License field; see https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios. Since you use cli11 as a header-only library, you must BuildRequire cli11-static. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
