[Bug 1914280] Review Request: radeon-profile - Application to read current clocks of ATi Radeon cards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1914280

Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> ---
> Note: Directories without known owners: /usr/share/icons/hicolor

1. Please add Requires: hicolor-icon-theme.

> for t in $(ls *.qm); do install -Dpm644 "$t" "%{buildroot}%{_datadir}/%{name}/$t"; done

2. I suggest to replace by find command:

find . -maxdepth 1 -name '*.qm' -exec install -Dpm644 '{}'
'%{buildroot}%{_datadir}/%{name}' \;

3. Please ask upstream to add AppData manifest file.

These minor issues can be fixed during import. Package approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux