https://bugzilla.redhat.com/show_bug.cgi?id=1912143 --- Comment #1 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- License should be ASL 2.0, not MIT. Per the upstream repo - looks like this was when the initial implementation took place, so the license is probably OK -- the version shipped with Python 3.7 is under the Python license, but if there's only one copyright owner they have the right to relicense. I wonder if we can find documentation for that though. You probably don't need the conditionals as the package will only ever be built on epel8? Also maybe add a version limit on BuildRequires: python3-devel. ``` %if 0%{?fedora} < 33 || 0%{?rhel} < 9 %py_provides python3-%{pypi_name} %endif ``` ``` BuildRequires: python3-devel >= 3.6 BuildRequires: python3-devel < 3.7 ``` The description is duplicated, you can reuse the definition: ``` %global _description %{expand: This package is an implementation of PEP 557, Data Classes. It is a backport for Python 3.6, as dataclasses is included in Python 3.7 and later.} %description %_description ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
