https://bugzilla.redhat.com/show_bug.cgi?id=1900274 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package generated with rust2rpm, simplifying review process. - package builds and installs on rawhide - License is correct (both for library and statically linked binary, since it has no external dependencies) - package follows Rust packaging Guidelines - Patches / PRs / divergence from rust2rpm-generated spec file justified Package APPROVED. Suggestions for improvement: Make names of patches and comments for them more descriptive, e.g.: # Use latest version of dependency Patch0: dependency-version.diff # Add exclusions to Cargo.toml # Cf. upstream PR: https://github.com/gimli-rs/leb128/pull/17 Patch1: exclude.diff becomes: # Initial patched metadata # * bump quickcheck from 0.8 to 0.9 # * exclude unnecessary CI files Patch0: leb128-fix-metadata.diff The filename is in line with what "rust2rpm -p" generates, and so this would also match other Rust packages. Could you review one of my pending Rust packages in return? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
