https://bugzilla.redhat.com/show_bug.cgi?id=1908922 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- According to wikipedia, this is the patent https://patents.google.com/patent/EP0398973B1/en, long expired. But please wait for ack from Legal before building this in Fedora. fedora-review says: - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib64/libopenaptx.so Please fix. + package name is OK + license is acceptable for Fedora (LGPLv2.1+) + license is specified correctly (LGPGv2+) + builds and installs OK + Provides/Requires/BuildRequires look OK + distro build flags are used + looks OK in general Rpmlint ------- Checking: libopenaptx-0.2.0-3.fc34.x86_64.rpm libopenaptx-devel-0.2.0-3.fc34.x86_64.rpm libopenaptx-tools-0.2.0-3.fc34.x86_64.rpm libopenaptx-debuginfo-0.2.0-3.fc34.x86_64.rpm libopenaptx-debugsource-0.2.0-3.fc34.x86_64.rpm libopenaptx-0.2.0-3.fc34.src.rpm libopenaptx.x86_64: W: spelling-error Summary(en_US) aptX -> apt X, apt, apex libopenaptx.x86_64: W: spelling-error %description -l en_US aptX -> apt X, apt, apex libopenaptx.x86_64: W: spelling-error %description -l en_US ffmpeg -> MPEG libopenaptx.x86_64: W: no-documentation libopenaptx-devel.x86_64: W: no-documentation libopenaptx-tools.x86_64: W: no-documentation libopenaptx-tools.x86_64: W: no-manual-page-for-binary openaptxdec libopenaptx-tools.x86_64: W: no-manual-page-for-binary openaptxenc libopenaptx.src: W: spelling-error Summary(en_US) aptX -> apt X, apt, apex libopenaptx.src: W: spelling-error %description -l en_US aptX -> apt X, apt, apex libopenaptx.src: W: spelling-error %description -l en_US ffmpeg -> MPEG → False positives. libopenaptx-devel.x86_64: E: rpath-in-buildconfig /usr/lib64/pkgconfig/libopenaptx.pc lines ['9'] Yeah, the .pc files is borked: > prefix=/usr/lib64 > exec_prefix=${prefix} > libdir=${exec_prefix}//usr/include → this evaluates to libdir=/usr/lib64//usr/include > Libs: -Wl,-rpath=${libdir} -L${libdir} -lopenaptx → this sets rpath, and it shouldn't. > Cflags: -I${includedir} → this gets the include path wrong ;( I think it'd be easiest to do something like sed -r -i 's/^Libs:.*/Libs: -lopenaptx/; /Cflags:/d' /path/to/.pc libopenaptx-tools.x86_64: W: summary-not-capitalized C libopenaptx encoder and decoder utilities libopenaptx-tools.x86_64: E: description-line-too-long C The libopenaptx-tools package contains openaptxenc encoder and openaptxdec decoder → Maybe "AptX encoding and decoding tools" 6 packages and 0 specfiles checked; 2 errors, 12 warnings. Package is APPROVED, conditional on Legal review. Please fix issues listed above before upload. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
