https://bugzilla.redhat.com/show_bug.cgi?id=1910504 code@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx --- Comment #6 from code@xxxxxxxxxxxxxxxxxx --- I’m not doing a full review at this time, but here are a few things I noticed: The upstream package contains bindings for Python, Lua, and Haskell. All of these would be useful in Fedora. I think the package is incomplete without these language bindings. “V=1 make %{?_smp_mflags}” would be better expressed as “%make_build”, and “V=1 make %{?_smp_mflags} check” would be better expressed as “%make_build check”. An accepted change for Fedora 34 is that packages using make must BR it explicitly (“BuildRequires: make”). The guidelines have not yet been updated. In python/setup.py, the metadata claims an MIT license; however, the overall license of the source tarball is BSD. None of the Pythong binding sources have a license/copyright comment. Since MIT is by far the most common license in Python land, this is a possible copy-paste error. Upstream should be queried to clarify the license of the Python bindings. If MIT is intended, upstream should be asked to include a file in the python/ subdirectory with the license text. Note that the MIT license would *require* the license text to accompany any distribution. See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/. Currently, the python bindings are not packaged, but I think they should be. If upstream states they are MIT-licensed and adds a license file, then the python3-ucl subpackage will have license “MIT”. The contents of the klib subdirectory are MIT-licensed and have the same issue. Additionally, they comprise a bundled static (header-only) partial copy of the klib library (https://attractivechaos.github.io/klib/). See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries and also https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling for options. These sections of the guidelines have changed quite a bit recently. Similarly, src/tree.h is MIT-licensed and is a bundled static (header-only) copy of https://piumarta.com/software/tree/. Similarly, src/mum.h is MIT-licensed and is a bundled static (header-only) copy of https://github.com/vnmakarov/mum-hash. The overall license of the main package will be “BSD and MIT” unless *all* MIT-licensed bundled libraries are unbundled and removed in prep. You should be able to just pass --disable-static to the configure script (“%configure --disable-static”) instead of patching the call to LT_INIT in configure.ac. The patch to remove the trailing slash from libucl.pc.in should be sent upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
