[Bug 1911780] Review Request: R-gitcreds - Query 'git' Credentials from 'R'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1911780

José Matos <jamatos@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jamatos@xxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |jamatos@xxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from José Matos <jamatos@xxxxxxxx> ---
The license is correct and appropriated for Fedora.
The spec file is simple and correct.

fedora-review complains:
- Package have the default element marked as %%doc :DESCRIPTION
- Package requires R-core.

The only pattern that I am seeing here is the number of 0.1.1 packages that are
introduced in the updates of R packages. :-)

After reviewing so many packages the other thing that shows up is that probably
the %install section could get a macro on R-rpm-macros since this chunk appears
so many times:

mkdir -p %{buildroot}%{rlibdir}
%{_bindir}/R CMD INSTALL -l %{buildroot}%{rlibdir} %{packname}
test -d %{packname}/src && (cd %{packname}/src; rm -f *.o *.so)
rm -f %{buildroot}%{rlibdir}/R.css

The package is approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux