https://bugzilla.redhat.com/show_bug.cgi?id=1911565 --- Comment #3 from Derek Pressnall <derekp7@xxxxxxxxxxxxxxxx> --- I have made the requested adjustments, and some additional cleanup in the spec file. Will look into the libeconf suggestion for the config file as part of the upstream project, however the config is minimal (containing a path to the catalog database and file repositories). In the upstream project, future configuration items may be planned to be handled out of the SQLite DB used for the backup catalog in something like a sysparams table (at that point, even the "vault=" specification can be migrated to the DB). Still weighing the pros and cons of that. Currently there isn't publicly available unit tests, all testing at the moment requires manual intervention. However that will be automated in an upcoming release. In that case, what type of resources does the Fedora build infrastructure have available for testing? For example, simple tests could be made to create sample directories to backup up and verify, with verification of the expiration/purge processes. However, some tests require creation of various sparse files with varying amount of "holes" (this test the ability to ingest GNU tar format sparse entries -- there are edge cases in the format at 4 holes, 24, and multiples of 20 afterwards, so testing should include the boundary points). Also GNU tar switches file size representation at 2GB (switches from octal to network byte order binary format). So that would require large files to test against. For now, will concentrate on the minimal test cases to ensure basic functionality though. I do have one question in the Source specification. The Sourc0 line has the full URL for the upstream source. Is a full URL also required for Source1, which points to the ".sysusers" file consumed by %sysusers_create_compat? It appears to not have a URL specified in other spec files I've looked at. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
