https://bugzilla.redhat.com/show_bug.cgi?id=1910991 José Matos <jamatos@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from José Matos <jamatos@xxxxxxxx> --- (In reply to Kevin Fenzi from comment #2) > Good question. Those dll files are for pyqt-bundler which allows someone to > bundle os stuff in their windows binary. Some of them are openssl, and some > of them are microsoft visual basic (redistributable). They aren't made from > source, and I don't think too many people will be using this package on > linux to build and bundle windows binaries, so I am fine with just dropping > them. > > I did look and opensuse ships them. Debian doesn't seem to package > pyqt-builder at all, so no help there. > > New version, with dlls removed: > > Spec URL: > https://scrye.com/~kevin/fedora/review/PyQt-builder/PyQt-builder.spec > SRPM URL: > https://scrye.com/~kevin/fedora/review/PyQt-builder/PyQt-builder-1.6.0-2. > fc34.src.rpm My view point was from the license angle, at most that status should have been declared in the spec file. :-) Something like BSD and Redistributable or something equivalent. Honestly I trust your judgement here. :-) The package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
