[Bug 1910990] Review Request: python-sgmllib3k - python3 copy of sgmllib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1910990

José Matos <jamatos@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |jamatos@xxxxxxxx
              Flags|                            |fedora-review+



--- Comment #2 from José Matos <jamatos@xxxxxxxx> ---
Cool, fedora-review accepted the fix. :-)

The license is correct and appropriated for Fedora.
The spec file is simple and correct.

fedora-review complains that:
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/lib/python3.9/site-
  packages/sgmllib.py
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_duplicate_files

Probably from %pycached %{python3_sitelib}/sgmllib.py?

A minor point is that probably the line after "%install":
rm -rf $RPM_BUILD_ROOT

can be removed, as it is not required anymore, even in EPEL.

I trust you to fix these on import.
The package is approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux