https://bugzilla.redhat.com/show_bug.cgi?id=1908040 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Thanks for the review! (In reply to dan.cermak from comment #1) > This looks good to me, I have just one thing to note: the package is > licensed under the GPLv2 with the classpath exception, but there is stuff > inside licensed under the BSD 3-clause (under jol-smaples/). And for some > reason there's a bunch of THIRD-PARTY files that include the Expat/MIT > license. Do you know what's the matter here? Since the package is otherwise > good, I'll approve it and let you handle the license situation as you see > fit. The jol-samples files do not go into any binary RPM, so we don't need to worry about their licenses. The Expat/MIT license applies to jopt-simple, which this package consumes. Since that code is not bundled, just used, there is no need to worry about that license either, in my opinion. We simply use the jopt-simple jars; see the Requires for jol-cli. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
