https://bugzilla.redhat.com/show_bug.cgi?id=1907976 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Kevin Fenzi <kevin@xxxxxxxxx> --- (In reply to Torrey Sorensen from comment #4) > Spec URL: > https://gitlab.com/fedora-mobile/megapixels/-/raw/master/megapixels.spec > SRPM URL: > https://download.copr.fedorainfracloud.org/results/njha/mobile/fedora- > rawhide-aarch64/01841904-megapixels/megapixels-0.13.1-2.fc34.src.rpm > Copr Build: > https://copr.fedorainfracloud.org/coprs/njha/mobile/build/1841904/ > > > 1. Why %global debug_package %{nil} ? Don't we want debuginfo? > > Yes, we want debuginfo. Removed that line. Thanks. > > 2. The package seems to include the inih package bundled in. > > Might see if you can get it to use inih-devel already packaged in Fedora? > > If not, you may have to Provides: bundled(inih) > > I added inih-devel to BuildRequires. It doesn't seem to be using it? Not a blocker, but perhaps ask upstream to detect and use a system version if available? > > 3. Need to own /usr/share/megapixels and /usr/share/megapixels/config > > (either via %dir in files, or changing the globbing) > > Fixed :) Thanks. > > 4. DEBUG util.py:444: warning: bogus date in %changelog: > > Wed Dec 03 2020 Torrey Sorensen <sorensentor@xxxxxxx> - 0.12.0-2 > > The 3rd was a thursday. ;) > > oof, that was dumb of me. Naw, happens to everyone. ;) > > 5. It doesn't seem to work here on x86_64: > > As mentioned I added ExclusiveArch for the two arm arches. > > Tested and still works "as expected" on the PinePhone. > > > Thank you for the review. Cool. All blockers I see are fixed. Please check into the inih thing with upstream when you get a chance... This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
