https://bugzilla.redhat.com/show_bug.cgi?id=1894605 --- Comment #18 from John Kacur <jkacur@xxxxxxxxxx> --- (In reply to Jaroslav Škarvada from comment #15) > John I will sponsor you. Few things I noted, please fix them: > > - The following lines are not needed, the implicit deps generator is quite > good: > %{?__python3:Requires: %{__python3}} > ... > Requires: bash > > - The following line is not needed, please drop it: > rm -rf %{buildroot} > > - Please escape macros in the changelog, i.e. > in the changelog change %description to %%description, and also probably > change %s to %%s and %ld to %%ld > > Another thing I am just curious about: > - Isn't better (and safer) to just state that only root could run it instead > of giving it caps? > %caps(cap_sys_rawio+ep) /usr/bin/cyclictest I removed %{?__python3:Requires: %{__python3}} rm -rf %{buildroot} and I escaped all the macros as you requested. cyclictest uses caps to grant the user who joins the realtime group access to smi registers in the analysis of realtime performance. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
