https://bugzilla.redhat.com/show_bug.cgi?id=1896303 --- Comment #4 from Qiyu Yan <yanqiyu01@xxxxxxxxx> --- (In reply to Aleksei Bavshin from comment #3) > More nitpicking after running fedora-review: > > > [ ]: License field in the package spec file matches the actual license. > > Surprisingly, FindDDCUtils.cmake has BSD license header. libddcutil-devel > license tag should reflect that. Changed. > The rest of licensecheck output is a noise from autotools and generated code. > > > [ ]: Package must own all directories that it creates. > > Note: Directories without known owners: /usr/lib64/cmake > > Please, add `Requires: cmake-filesystem%{?_isa}` to devel package (adding > `BuildRequires: cmake` would achieve the same effect with more magic > involved). Changed. > > > ddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/ddcutil/ChangeLog > > ddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/ddcutil/NEWS.md > > Don't know if it's worth fixing, but simple chmod in %prep could take care > of that. fixed. > > > i2c-tools has `ExcludeArch: s390 s390x`. Feel free to do the same, with a > comment explaining why ExcludeArch is needed. fixed. > > > Does libddcutil have the same set of runtime dependencies? It don't seem so. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
