https://bugzilla.redhat.com/show_bug.cgi?id=1902632 Aniket Pradhan <aniketpradhan1999@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Aniket Pradhan <aniketpradhan1999@xxxxxxxxx> --- That's great if you can package the latest version. Just a bit small nits, 1. Please leave a small comment in the spec, about why you're disabling the tests. 2. If possible, please report the issues in the tests to upstream, so that they can patch it up. 3. I believe there are other tests in the project directory, so I guess there's no need to manually specify a particular directory and let pytest discover the tests automatically. Other than that, the spec is amazing, and I am approving the review. After doing the above changes, you can manually proceed with the repo creation! Good Luck :D -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
