https://bugzilla.redhat.com/show_bug.cgi?id=1904696 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@xxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- Some notes: - Requires Perl and perl modules are missing: https://git.fws.fr/fws/virt-backup/src/branch/master/virt-backup.spec#L16 - Why patch the .spec file from tarball with virt-backup-update.patch if it not going to be installed/used? - _sharedstatedir can be used instead of _localstatedir - Is the changelog correct? I understand that you took Daniel's version and changed it. You can change Release to 2 and add a new Changelog entry. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx