https://bugzilla.redhat.com/show_bug.cgi?id=1885503 Andy Mender <andymenderunix@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |susi.lehtola@xxxxxx --- Comment #2 from Andy Mender <andymenderunix@xxxxxxxxx> --- I just noticed I assigned myself, but didn't complete the review earlier. I'm terribly sorry :/. Version 0.17.0 is actually out already, impressive: https://github.com/spacemanspiff2007/HABApp/releases/tag/0.17.0 Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=56626137 > BuildRequires: python3dist(aiohttp-sse-client) > %{?python_provide:%python_provide python3-%{pypi_name}} Please, switch to the %py_provides macro > # Multiples are failing with 0.16.2 > #%%check > # Two test are failing > #%%pytest -v tests -k "not test_run_func and not test_run_func_no_cap" I'm unsure about this. I re-enabled the tests and it seems a couple of things are missing: BuildRequires: python3dist(tzlocal) BuildRequires: python3dist(paho-mqtt) But there seems to be a bug in python3-pedantic as well: + /usr/bin/pytest -v tests -k 'not test_run_func and not test_run_func_no_cap' ImportError while loading conftest '/builddir/build/BUILD/HABApp-0.16.2/tests/conftest.py'. tests/__init__.py:1: in <module> from .rule_runner import SimpleRuleRunner tests/rule_runner/__init__.py:1: in <module> from .rule_runner import SimpleRuleRunner tests/rule_runner/rule_runner.py:6: in <module> from HABApp.core import WrappedFunction HABApp/__init__.py:14: in <module> import HABApp.mqtt HABApp/mqtt/__init__.py:2: in <module> from . import items HABApp/mqtt/items/__init__.py:1: in <module> from .mqtt_item import MqttItem HABApp/mqtt/items/mqtt_item.py:1: in <module> import HABApp.mqtt.mqtt_interface HABApp/mqtt/mqtt_interface.py:5: in <module> from .mqtt_connection import MqttConnection, log HABApp/mqtt/mqtt_connection.py:9: in <module> from HABApp.runtime.shutdown_helper import ShutdownHelper HABApp/runtime/__init__.py:3: in <module> from .runtime import Runtime HABApp/runtime/runtime.py:7: in <module> import HABApp.util HABApp/util/__init__.py:5: in <module> from . import multimode HABApp/util/multimode/__init__.py:1: in <module> from .mode_base import BaseMode HABApp/util/multimode/mode_base.py:32: in <module> from .item import MultiModeItem # noqa: E402 HABApp/util/multimode/item.py:9: in <module> from HABApp.rule import get_parent_rule HABApp/rule/__init__.py:2: in <module> from .rule import Rule, get_parent_rule HABApp/rule/rule.py:13: in <module> import HABApp.openhab HABApp/openhab/__init__.py:3: in <module> import HABApp.openhab.events HABApp/openhab/events/__init__.py:2: in <module> from .item_events import ItemStateEvent, ItemStateChangedEvent, ItemCommandEvent, ItemAddedEvent,\ HABApp/openhab/events/item_events.py:4: in <module> from ..map_values import map_openhab_values HABApp/openhab/map_values.py:3: in <module> from HABApp.openhab.definitions import HSBValue, OnOffValue, OpenClosedValue, PercentValue, QuantityValue, RawValue, \ HABApp/openhab/definitions/__init__.py:3: in <module> from . import rest HABApp/openhab/definitions/rest/__init__.py:1: in <module> from .items import OpenhabItemDefinition HABApp/openhab/definitions/rest/items.py:55: in <module> OpenhabItemDefinition.update_forward_refs() /usr/lib/python3.9/site-packages/pydantic/main.py:677: in update_forward_refs update_field_forward_refs(f, globalns=globalns, localns=localns) /usr/lib/python3.9/site-packages/pydantic/typing.py:233: in update_field_forward_refs field.type_ = evaluate_forwardref(field.type_, globalns, localns or None) /usr/lib/python3.9/site-packages/pydantic/typing.py:50: in evaluate_forwardref return type_._evaluate(globalns, localns) E TypeError: _evaluate() missing 1 required positional argument: 'recursive_guard' error: Bad exit status from /var/tmp/rpm-tmp.4OhOov (%check) Bad exit status from /var/tmp/rpm-tmp.4OhOov (%check) This was addressed here: https://github.com/samuelcolvin/pydantic/issues/1985 And is already presumably in the latest 1.7.3 release, but our python3-pydantic is at 1.6.1 and no new version in Rawhide: https://src.fedoraproject.org/rpms/python-pydantic I added Susi who's the maintainer of python-pydantic to this ticket. Other than that, python-habapp looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
