https://bugzilla.redhat.com/show_bug.cgi?id=1896368 --- Comment #4 from Miroslav Lichvar <mlichvar@xxxxxxxxxx> --- Here is fixed spec and srpm: https://fedorapeople.org/~mlichvar/tmp/ntpsec.spec https://fedorapeople.org/~mlichvar/tmp/ntpsec-1.2.0-2.fc34.src.rpm (In reply to Andy Mender from comment #2) > > Conflicts: ntp ntpdate > > Obsoletes: ntp < 4.2.8p16 ntpdate < 4.2.8p16 > > Would it make sense to also add a Provides entry to the SPEC file? As this is not a full replacement of ntp, I think it would be incorrect to provide "ntp". > > # Fix egg info to use a shorter version which will work as an rpm provide > > sed -i 's|NTPSEC_VERSION_EXTENDED|NTPSEC_VERSION|' pylib/ntp-in.egg-info > > [...] > > # Modify default configuration > > sed -i -e '/^pool .*pool\.ntp\.org/s|[^ ]*pool.ntp.org|2.%{vendorzone}\0|' \ > > -e '/^pool /a # Reduce the number of used servers\ntos maxclock 5' \ > > -e '/^pool /G' \ > > etc/ntp.d/use-pool > > sed -i '/^logfile/d' etc/ntp.d/use-performance-logging > > Are these changes relevant only to the Fedora package or would it make sense > to submit them upstream as patches? The pool vendor name is downstream specific. I've submitted an upstream PR for the maxclock line. > ntpsec.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ntp/libntpc.so > Review: Do we want a -devel subpackage or is this SO file for internal use > only? It is for ntpsec's internal use. There are no header files installed. > ntpsec.x86_64: W: log-files-without-logrotate ['/var/log/ntpstats'] > Review: Missing Requires on logrotate? I've added a logrotate file and owned the directory to avoid a hard dependency on logrotate, as there should be no logs generated in the default configuration. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
