https://bugzilla.redhat.com/show_bug.cgi?id=1895696 --- Comment #15 from ycollet <ycollette.nospam@xxxxxxx> --- (In reply to Andy Mender from comment #14) > > Source0: %{url}/archive/%{name}-%{version}.tar.gz > > Patch0: libsmf-0001-fixe-various-problems.patch > > Add a comment above the Patch0 line explaining why the patch is needed. You > mentioned a memory leak earlier. I think that should also feature in the > SPEC file. > Also, if the patch fixes several unrelated issues, it's perhaps better to > split it into multiple patch records so that they can be addressed > individually later (for instance, by upstream). I added all the patches from the PR (8 patches). The title of the patches are informative enough I think. > > BuildRequires: gcc > > BuildRequires: gcc-c++ > > BuildRequires: autoconf > > BuildRequires: automake > > BuildRequires: libtool > > BuildRequires: pkgconfig > > BuildRequires: glib2-devel > > BuildRequires: doxygen > > Since you're using make, add it as a BuildRequires as well. Added > > > Can you be a little bit more specific about "make sure somethin ..." ? > > I added the doc subpackage > > Yes, apologies. What I meant is that currently, the api subdir is not owned > properly: > > %files doc > > %{_datadir}/doc/%{name}/api/* > > The last line means that all content in the directory is owned, but not the > directory itself. You have the following options: > > %{_datadir}/doc/%{name}/api/ Added The spec file: https://raw.githubusercontent.com/ycollet/fedora-spec/master/libsmf/libsmf.spec The src rpm file: https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-33-x86_64/01805954-libsmf/libsmf-1.3-8.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
