https://bugzilla.redhat.com/show_bug.cgi?id=1902309 Andy Mender <andymenderunix@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Andy Mender <andymenderunix@xxxxxxxxx> --- Looks a lot better :) A couple of minor points: > %install > rm -Rf %{buildroot} > %make_install DEST=%{buildroot} install - BuildRoot clean-up is not needed. It's executed automatically. - The default DEST is %{buildroot} by default so it too can be removed. > [amender@localhost realtime-setup]$ rpm --eval %make_install > /usr/bin/make install DESTDIR=/home/amender/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64 INSTALL="/usr/bin/install -p" > [amender@localhost realtime-setup]$ rpm --eval %{buildroot} > /home/amender/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64 The rest looks fine. Approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
