https://bugzilla.redhat.com/show_bug.cgi?id=1895696 --- Comment #12 from ycollet <ycollette.nospam@xxxxxxx> --- > When pointing to the SPEC file, try to point directly to the raw file itself > like so: > https://raw.githubusercontent.com/ycollet/fedora-spec/master/libsmf/libsmf. > spec Ah, yes, I forgot to click on the raw button on github ... > > Source0: https://github.com/stump/%{name}/archive/%{name}-%{version}.tar.gz > > You can re-use URL in the Source0 field like so: > Source0: %{url}/archive/%{name}-%{version}.tar.gz > Also, any reason URL doesn't use %{name}? Added %{url} > > BuildRequires: gcc gcc-c++ Splitted ... > Split these into separate lines like the other BuildRequires. Done. > - Documentation should go into a -doc subpackage. > - Also, make sure something owns the %{_datadir}/doc/%{name}/api/ subdir. Can you be a little bit more specific about "make sure somethin ..." ? I added the doc subpackage > - This is not mandatory, but could you be slightly more specific about the > packaged content inside %{_includedir}? > - Also, libtool archives should not be packaged. Please, remove them at the > end of the %build step. I fixed the %{includedir} part + I remove the la file > > %changelog > > * Sat Nov 08 2020 Yann Collette <ycollette dot nospam at free.fr> 1.3-5 > > - fix spec file > > Nov 8th was a Sunday. Date fixed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
