https://bugzilla.redhat.com/show_bug.cgi?id=1902309 --- Comment #2 from Andy Mender <andymenderunix@xxxxxxxxx> --- > SRPM URL: https://jcwillia.fedorapeople.org/realtime-setup-2.1-1.fc33.x86_64.rpm That's actually the final RPM, I think. Koji build from a new SRPM: https://koji.fedoraproject.org/koji/taskinfo?taskID=56365885 > License: GPL+ > Summary: Setup RT/low-latency environment details > Group: System Environment/Base > Source: https://jcwillia.fedorapeople.org/realtime-setup-%{version}.tar.bz2 - The Group field is no longer used in Fedora. - The Source field should be called Source0 and the URL field is missing > BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) Declaring the BuildRoot explicitly is also not needed anymore. > BuildRequires: gcc > BuildRequires: systemd > BuildRequires: annobin > Requires: pam >= 0.99.6.2-3.26 > Requires: /usr/sbin/groupadd > Requires: kexec-tools > Requires: tuna > Requires: tuned > Requires: tuned-profiles-realtime > Requires: systemd - BuildRequires and Requires on systemd are most likely not needed, but a BuildRequires on systemd-rpm-macros is needed to make use of extra rpm macros related to packaging systemd services. - groupadd is a part of the base system so can be omitted as well. - make should be added to BuildRequires as now it's considered an explicit dependency - Fedora 32 ships pam 1.3.1 so the version requirement for pam can be dropped as well > %global debug_package %{nil} It's alright to disable creation of -debuginfo packages, but there should be a comment above explaining why it's done :). > %description > The realtime-setup package configures details useful for low-latency environments. The first line of the description is too long. > %build > %set_build_flags > make all > > %install > rm -Rf %{buildroot} > make DEST=%{buildroot} install - %set_build_flags is probably not needed anymore - "make all" should be invoked with the %make macro - cleaning the buildroot is not needed - "make install" should be invoked with the %make_install macro > %preun > if [ "$1" = "0" ] ; then # uninstall > systemctl disable realtime-setup > fi - Not sure whether disabling the service is needed, but there are a couple of extra macros specific to systemd services: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd > %clean > rm -rf %{buildroot} - The buildroot is automatically removed so this block can also be removed > %files > %defattr(0644,root,root,0755) > %config(noreplace) %{_sysconfdir}/security/limits.d/realtime.conf > %config(noreplace) %{_sysconfdir}/udev/rules.d/99-rhel-rt.rules > %config(noreplace) %{_sysconfdir}/sysconfig/realtime-setup > %attr(0755, root, root) %{_bindir}/slub_cpu_partial_off > %attr(0755, root, root) %{_sbindir}/realtime-entsk > %attr(0755, root, root) %{_sbindir}/kernel-is-rt > %attr(0644, root, root) %{_unitdir}/realtime-setup.service > %attr(0755, root, root) %{_bindir}/realtime-setup > %attr(0644, root, root) %{_unitdir}/realtime-entsk.service - The %defattr and %attr invocations can also be removed, as far as I know, unless the default permissions are different for these files (they shouldn't be). - License file missing. Not a 100% sure whether it's mandatory in this case, though. Full review below: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in realtime-setup See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets Review: related to the linked systemd macros mentioned before ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 11 files have unknown license. Detailed output of licensecheck in /data/rpmbuild/SPECS/realtime- setup/realtime-setup/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [ ]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed Review: mentioned earlier. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [!]: Uses parallel make %{?_smp_mflags} macro. [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Scriptlets must be sane, if used. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. Review: running raw "make install" doesn't add the needed "-p" flag. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: realtime-setup-2.1-1.fc34.x86_64.rpm realtime-setup-2.1-1.fc34.src.rpm realtime-setup.x86_64: W: spelling-error %description -l en_US irqs -> iris, irks realtime-setup.x86_64: W: spelling-error %description -l en_US dev -> deb, derv, div realtime-setup.x86_64: W: spelling-error %description -l en_US rtc -> ctr, etc, rt realtime-setup.x86_64: W: spelling-error %description -l en_US slub -> sub, slue, slab realtime-setup.x86_64: W: spelling-error %description -l en_US cpu -> CPU, cup, cu realtime-setup.x86_64: W: spelling-error %description -l en_US timestamp -> time stamp, time-stamp, times tamp realtime-setup.x86_64: W: spelling-error %description -l en_US entsk -> entente realtime-setup.x86_64: W: spelling-error %description -l en_US allocator's -> locator's, allocation's, alligator's realtime-setup.x86_64: W: spelling-error %description -l en_US timestamping -> time stamping, time-stamping, times tamping realtime-setup.x86_64: W: spelling-error %description -l en_US progam -> program realtime-setup.x86_64: E: description-line-too-long C The realtime-setup package configures details useful for low-latency environments. realtime-setup.x86_64: W: incoherent-version-in-changelog 2.1.1 ['2.1-1.fc34', '2.1-1'] realtime-setup.x86_64: W: no-url-tag realtime-setup.x86_64: W: no-documentation realtime-setup.x86_64: W: udev-rule-in-etc /etc/udev/rules.d/99-rhel-rt.rules realtime-setup.x86_64: W: no-manual-page-for-binary realtime-setup realtime-setup.x86_64: W: no-manual-page-for-binary slub_cpu_partial_off realtime-setup.x86_64: W: no-manual-page-for-binary kernel-is-rt realtime-setup.x86_64: W: no-manual-page-for-binary realtime-entsk realtime-setup.src: W: spelling-error %description -l en_US irqs -> iris, irks realtime-setup.src: W: spelling-error %description -l en_US dev -> deb, derv, div realtime-setup.src: W: spelling-error %description -l en_US rtc -> ctr, etc, rt realtime-setup.src: W: spelling-error %description -l en_US usr -> use, us, user realtime-setup.src: W: spelling-error %description -l en_US slub -> sub, slue, slab realtime-setup.src: W: spelling-error %description -l en_US cpu -> CPU, cup, cu realtime-setup.src: W: spelling-error %description -l en_US timestamp -> time stamp, time-stamp, times tamp realtime-setup.src: W: spelling-error %description -l en_US entsk -> entente realtime-setup.src: W: spelling-error %description -l en_US allocator's -> locator's, allocation's, alligator's realtime-setup.src: W: spelling-error %description -l en_US timestamping -> time stamping, time-stamping, times tamping realtime-setup.src: W: spelling-error %description -l en_US progam -> program realtime-setup.src: E: description-line-too-long C The realtime-setup package configures details useful for low-latency environments. realtime-setup.src: W: no-url-tag 2 packages and 0 specfiles checked; 2 errors, 30 warnings. Rpmlint (installed packages) ---------------------------- (none): E: no installed packages by name realtime-setup 0 packages and 0 specfiles checked; 0 errors, 0 warnings. Source checksums ---------------- https://jcwillia.fedorapeople.org/realtime-setup-2.1.tar.bz2 : CHECKSUM(SHA256) this package : 98d7f8e8d06c434db8b01ff690784dc68c6d96506386e108d02fb26be410e678 CHECKSUM(SHA256) upstream package : 98d7f8e8d06c434db8b01ff690784dc68c6d96506386e108d02fb26be410e678 Requires -------- realtime-setup (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash /usr/sbin/groupadd config(realtime-setup) kexec-tools libc.so.6()(64bit) pam rtld(GNU_HASH) systemd tuna tuned tuned-profiles-realtime Provides -------- realtime-setup: config(realtime-setup) realtime-setup realtime-setup(x86-64) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
