https://bugzilla.redhat.com/show_bug.cgi?id=1898135 Andy Mender <andymenderunix@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Andy Mender <andymenderunix@xxxxxxxxx> --- > %check > pushd %{buildroot}%{python3_sitearch}/%{module_name} > %{__python3} -m pytest > rm -rf .pytest_cache > rm tests/__pycache__/test_erfa*pytest*.pyc > popd Not sure about this bit here. Did you try running the tests by only invoking the %pytest macro directly in the buildroot (without the pushd/popd directory stack changes)? So something like this: > %check > %pytest The %pytest macro unwinds into a pytest call with a bit of Fedora-specific extras. > %files -n python%{python3_pkgversion}-%{pypi_name} > %license LICENSE.rst Leftover %{python3_pkgversion}. You can remove it as well. I don't think the helper libtool/m4 libraries end up in the package so no need to worry about them. Looks good otherwise. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
