[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1883732



--- Comment #10 from Pavel Valena <pvalena@xxxxxxxxxx> ---
(In reply to Vít Ondruch from comment #9)
> Just to make it clear, I am reviewing this .spec file and SRPM:

Yes, that's the .spec file I was pointing to, for review.


>     Obviously, we still have rubygem-sass-rails, which was not build for
> Rails 6+. So you need bootstrap or rethink the BRs.


I've built rubygem-sass-rails in the side-tag f34-build-side-32997:

  https://koji.fedoraproject.org/koji/taskinfo?taskID=56151529

Yes, you're right, It's needed:

```nothing provides (rubygem(sassc-rails) >= 2.1 with rubygem(sassc-rails) < 3
with rubygem(sassc-rails) >= 2.1.1) needed by
rubygem-sass-rails-6.0.0-1.fc34.noarch```

I've added appropriate bcond_with macros. I opted to add them for this package,
as only build phase is affected.

Change:  https://git.io/JkPvI
Spec:   
https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedora-rawhide-x86_64/01785216-rubygem-sassc-rails/rubygem-sassc-rails.spec
SRPM:   
https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedora-rawhide-x86_64/01785216-rubygem-sassc-rails/rubygem-sassc-rails-2.1.2-1.4.fc34~bootstrap.src.rpm

Koji build (in side-tag):
https://koji.fedoraproject.org/koji/taskinfo?taskID=56152403
COPR build:               https://copr.fedorainfracloud.org/coprs/build/1785216

Note: For real build I'll reset the release to `1`, off course.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux