https://bugzilla.redhat.com/show_bug.cgi?id=1877006 --- Comment #6 from Jordi Sanfeliu <jordi@xxxxxxxxxxxx> --- (In reply to Robert-André Mauchin 🐧 from comment #5) > - NOt needed: > > BuildRequires: systemd-units > > Requires(post): systemd-units > Requires(preun): systemd-units > Requires(postun): systemd-units > > Use: > > BuildRequires: systemd-rpm-macros OK, done. Thanks. > - Not needed, this is already taken care of by Requires(pre): shadow-utils > : > > Requires(pre): /usr/bin/getent, /usr/sbin/groupadd, /usr/sbin/useradd, > /usr/sbin/usermod > OK, done. Thanks. > - %set_build_flags OPTFLAGS="%{optflags}" > %make_build > > %set_build_flags define otpflags so this is meaningless. > > if you want to keep optflags like this just switch back to > > %make_build OPTFLAGS="%{optflags}" OK, done. Thanks. > also you need to define LDFLAGS similarly with %build_ldflags You mean I need to add the following line? %set_build_ldflags LDFLAGS="%{ldflags}" > > - Notify upstream about their obsoletet FSF address (don't patch it) > > > smf-spf.x86_64: E: incorrect-fsf-address /usr/share/licenses/smf-spf/COPYING > Filed a PR: <https://github.com/jcbf/smf-spf/pull/87> Waiting an answer from upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
