[Bug 1900069] Review Request: python-matrix-nio - A Matrix client library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1900069



--- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
(In reply to Andy Mender from comment #1)
> Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=56071222
> 
> > License:        MIT
> 
> The license is "ISC" according to the PyPi page:
> https://pypi.org/project/matrix-nio/
> 
> Also, licensecheck found a couple of files with the Apache 2 license:
> Apache License 2.0
> ------------------
> matrix-nio-0.15.2/nio/crypto/attachments.py
> matrix-nio-0.15.2/nio/crypto/key_export.py
> matrix-nio-0.15.2/nio/store/database.py
> matrix-nio-0.15.2/nio/store/models.py
> 
> So the License field should probably read: ASL 2.0 and ISC
> 
> The rest is okay. Please, fix it on package import. Approved! Full review
> below:

Thanks for the review Andy. Sorry, dunno how I missed the license. I'll fix
that before import. I'll request SCM now.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux