[Bug 1900189] Review Request: python-rdflib-jsonld - Python rdflib extension adding JSON-LD parser and serializer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1900189



--- Comment #2 from Aniket Pradhan <aniketpradhan1999@xxxxxxxxx> ---
> I think the %py_provides macro should be used instead:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
> #_the_py_provides_macro

Welp... I have not been updated with the guidelines for some time now :P
I'll use it instead

> 
> > %package doc
> > Summary:        %{summary}
> > BuildRequires:	%{py3_dist sphinx}
> 
> I might be wrong, but I think one should also add below to the -doc
> subpackage:
> Requires: python3-%{pypi_name}%{?_isa} = %{version}-%{release}

I'm not sure too, since the docs and the package are separated out, so both
aren't dependent on each other. I'll still ask around.

> > %changelog
> > * Sat Nov 21 2020 Aniket Pradhan <major AT fedoraproject DOT org> - 0.5.1-1
> > - Initial build
> 
> The most recent release is 0.5.0 I think.

The errors of copy-pasta :P
I'll patch it.

> As these are minor, you can fix the issues on package import. Approved. Full
> review below:

Thanks for your review ^.^


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux