[Bug 1896742] Review Request: python3-radexreader - Reader for the RADEX RD1212 Geiger counter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1896742



--- Comment #11 from Andy Mender <andymenderunix@xxxxxxxxx> ---
> URL:         https://github.com/luigifab/python-radexreader
> Source0:     %{url}/archive/v%{version}.tar.gz

I see the Source0 field is still the same. One of the reasons
"%{name}-%{version}.tar.gz" is arguably better, is because it clearly
identifies your tarball. "v%{version}.tar.gz" is very ambiguous and can get
easily mixed up with other packages and tarballs.

> I kept the change in README.md to allow people that read the /usr/share/doc/python3-radexreader/README.md to known the "website" of the app.

I still think it makes more sense to have an extra section in the original
README (in the source tree, committed to git) with the URL, rather than
modifying the sources in the SPEC file. You can then cut a patch release,
1.0.1, with the change and everyone who has access to the sources can refer to
that feature.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux