https://bugzilla.redhat.com/show_bug.cgi?id=1899337 Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|pampelmuse@xxxxxx |nobody@xxxxxxxxxxxxxxxxx Flags|fedora-review+ | --- Comment #4 from Felix Schwarz <fschwarz@xxxxxxxxxxxxxxxxx> --- Hey Christoph, thank you very much for your time and welcome to Fedora :-). A few comments for future reviews: > [?]: License field in the package spec file matches the actual license. Nobody expects you to do a formal licensing audit but you can check the source code (e.g. check for a license header, lines in setup.cfg/setup.py). The "licensecheck" output itself is not always helpful. > [?]: Final provides and requires are sane (see attachments). If you check the Requires/Provides as shown by your fedora-review output you'll see that nothing crazy is coming up. The only interesting thing is that it just requires "python(abi)" while I expected something related to Python 3. Actually my local mockbuild produces a dependency on "python(abi) = 3.6" which looks better. I just double checked and the same is true for the COPR build (https://copr.fedorainfracloud.org/coprs/fschwarz/configobj-el7/). Unfortunately I think I have to reset the fedora-review flag as I think you are not a member of the packager group yet. > To show you familiarity with Fedora's guidelines perform unofficial (also called preliminary) reviews in other maintainers' package review request. Please clearly state when doing these reviews, that there are yet unofficial, and do not change the review requests status except for adding you to the CC list. https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Show_Your_Expertise_by_Commenting_on_other_Review_Requests If you are interested in Python packages there should be no shortage of work in Fedora. Feel free to send me an email when you need some guidance/help. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
