https://bugzilla.redhat.com/show_bug.cgi?id=1899776 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |ngompa13@xxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review? --- Comment #1 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: * Package is properly named per Packaging Guidelines * Package builds and installs correctly * Packaging follows Python Packaging Guidelines * Package does not include a license file Michel, could you switch to just pulling the release from GitHub instead of PyPI? That way, you'd have a license file. Alternatively, you can do something like what python-trololio does to get the license file included[1]. [1]: https://src.fedoraproject.org/rpms/python-trololio/blob/master/f/python-trololio.spec#_29-30 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
