https://bugzilla.redhat.com/show_bug.cgi?id=1872427 David Duncan <davdunc@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(davdunc@xxxxxxxxx | |m) | --- Comment #17 from David Duncan <davdunc@xxxxxxxxxx> --- (In reply to Neal Gompa from comment #16) > (In reply to Mohamed Aboubakr from comment #14) @nea I worked on this with Mohamed and I think we have a better submission this time, but looking forward to the next review. This was a super helpful review and I think this is more inline with the expectations. [...] > > error: Installed (but unpackaged) file(s) found: > > /usr/config/hibinit-config.cfg > > > > You should probably fix this in the code, because this is a legitimate > error. You have made a setup.py that installs a config file in the wrong > place. Either don't have the setup.py install the file, or adjust it to > install it to the correct location. > Mohamed is pushing the update to the github repo for setup.py so that the cfg file lands somewhere sane, not ```/usr/config``` [...] > > > If I shouldn't use py3_build_egg and use py3_build, what should I do in the > > above error ? > > You can just do the following for the Python metadata files: > > %{python3_sitelib}/ec2_hibinit_agent-%{version}-*.egg-info/ A spec file is up for review with the release changes and in anticipation of modify in setup.py to move back to /etc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
