https://bugzilla.redhat.com/show_bug.cgi?id=1872427 David Duncan <davdunc@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(davdunc@xxxxxxxxx | |m) --- Comment #15 from David Duncan <davdunc@xxxxxxxxxx> --- Hi Neal, > > %global release_number 3 > > Please use "baserelease" here, so that Release Engineering automation will > be able to correctly auto-bump the Release field. Alternatively, decouple > the upstream "release" field from the Release number being used in the > "Release:" tag. > Did not realize that was going on there. Will fix. > Recommendation for upstream: Don't tag versions with release numbers, just > bump the patch version. Ack. Will modify to ensure that we are not putting that at risk. > > > %py3_build_egg > > %py3_install_egg > > Why are we building eggs instead of just doing the normal "%py3_build" and > "%py3_install" macros? Egg installations mean that everything is installed > as a zip bundle rather than as files on disk. This is not the recommended > way to build Python stuff as RPMs. > > > Requires: python3 > > Requires: python3-setuptools > > This should no longer be needed, as they will be autogenerated correctly if > we install Python code the normal way. If you're also trying to build this > for EL8 without EPEL, you will also want to add the following at the top of > your spec: > > # Enable Python dependency generation > %{?python_enable_dependency_generator} > Ack, will add that in. That's important, thanks. > > %selinux_requires > > This requires "BuildRequires: selinux-policy, selinux-policy-devel". Also, > please do "%{?selinux_requires}" so that SRPM builds don't fail. > got it. Thanks. > > # Disable THP by switching to nothp_profile profile > > Is there a reason we're doing this? This enables workloads that don't include the following patch: https://lore.kernel.org/linux-mm/20200820045323.7809-1-hsiangkao@xxxxxxxxxx/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
