https://bugzilla.redhat.com/show_bug.cgi?id=1898100 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- The spec should be posted as a link, not in a comment. As for the links in the original post: a) The spec links points to an HTML web-view of the file. Please use "raw file" links. b) The SRPM link asks me to log in before I can fetch the file. > Review Request: beebeep - My first package that i want to contribute to the community The ticket title should describe what the package does. >Group: Applications/Communications Not used in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections >License: Qt Public License The LICENSE.txt file in the repo says that it's actually GPLv3. https://sourceforge.net/p/beebeep/code/HEAD/tree/LICENSE.txt >%global debug_package %{nil} This is generally a red flag. We *want* debuginfo to be generated. If your package fails to build without this line, it means that the binaries (i.e. executables and libraries) do not contain debug symbols; either they are compiled without debuginfo degeneration, or they are stripped at some point. https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/ >qmake-qt5 -recursive Use the "%qmake_qt5" macro here instead. It should set up Fedora's CXXFLAGS properly, possibly solving the issue with missing debuginfo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
