https://bugzilla.redhat.com/show_bug.cgi?id=1896742 --- Comment #1 from Andy Mender <andymenderunix@xxxxxxxxx> --- > Spec URL: https://github.com/luigifab/python-radexreader/blob/master/fedora/python3-radexreader.spec When linking a SPEC file, please point the URL to the raw content. Also, the SPEC file should be called "python-radexreader.spec". > Name: python3-radexreader Same here, the name should be "python-radexreader" > URL: https://github.com/luigifab/python-radexreader > Source0: https://github.com/luigifab/python-radexreader/releases/download/v%{version}/%{name}-%{version}.tar.gz You can re-use URL in the Source0 field as %{url} like so: %{url}/releases/download/v%{version}/%{name}-%{version}.tar.gz Also, the Source0 URL is incorrect. It should be like this: https://github.com/luigifab/python-radexreader/releases/download/v1.0.0/python-radexreader-1.0.0.tar.gz Notice that the name is actually "python-radexreader". > BuildRequires: python3-devel > Requires: python3 > Requires: python3-pyusb Python module Requires and BuildRequires should follow the format "python3dist(foo)". The SPEC file is missing the python3-radexreader subpackage, which is defined like this: %package -n python3-radexreader Summary: %{summary} %py_provides python3-radexreader %description -n python3-radexreader Description goes here You can define %global variables for "radexreader" and the %description blocks to avoid duplication, like so: %global pypi_name radexreader %global common_description %{expand: A multiple line description goes here.} > %install > %py3_install > mkdir -p %{buildroot}/lib/udev/rules.d/ %{buildroot}/usr/bin/ > cp -a udev.rules %{buildroot}/lib/udev/rules.d/60-python3-radexreader.rules > cp -a bin/radexreader %{buildroot}/usr/bin/radexreader > chmod +x %{buildroot}/usr/bin/radexreader The last 2 lines can probably be replaced with an "install" call: install -p -m755 bin/radexreader %{buildroot}/usr/bin/radexreader Also, you should avoid using "/usr/bin" directly and use the "%{_bindir}" macro instead. > %files > %{python3_sitelib}/radexreader/ > %{python3_sitelib}/radexreader*egg-info/ > /lib/udev/rules.d/60-python3-radexreader.rules > /usr/bin/radexreader The files should belong to the python3-radexreader subpackage. I'll run the full review matrix once these are fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
