https://bugzilla.redhat.com/show_bug.cgi?id=1897460 --- Comment #2 from Robin Lee <robinlee.sysu@xxxxxxxxx> --- Change: - Requires dbus-common Spec URL: https://download.copr.fedorainfracloud.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01768952-deepin-session-shell/deepin-session-shell.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01768952-deepin-session-shell/deepin-session-shell-5.3.0.22-2.fc34.src.rpm (In reply to Qiyu Yan from comment #1) > - Why the usage of %{?fedora}, will this spec file be used to build for > other distros? While I think it is better to leave only fedora (or epel) > suport here. As I said in the first comment, we work with upstream to create a unified specfile for different distributions. This makes the life of the Fedora packager happier. > - Add dbus-common as dependency Done. > > Issues: > ======= > - Package installs a %{name}.desktop using desktop-file-install or desktop- > file-validate if there is such a file. > False alarm, /usr/share/xgreeters/lightdm-deepin-greeter.desktop isn't > application desktop file > - Dist tag is present. > using %{?fedora:%dist}, but why? Another targeted distribution of this specfile, openEuler, don't use %dist. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
