Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cups-appletalk - Appletalk printers via CUPS https://bugzilla.redhat.com/show_bug.cgi?id=249122 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-11-07 21:25 EST ------- I suspect mention of appletalk has scared off reviewers, and I haven't hardware to test this against in over a decade, but it's a trivial package (one shell script!) so let's take a look. "Builds" OK on rawhide. rpmlint says: cups-appletalk.noarch: W: invalid-license GPL More specificity is needed. The source doesn't include any license statement but the README file says "gpl v2" so it looks like you should use "GPLv2" as the License: tag. However, see below. cups-appletalk.noarch: E: only-non-binary-in-usr-lib Well, you have to put it where cups stores its backends, so this is OK. Where does the tarball come from? The URL just seems to point to a copy of the shell script; is there no actual upstream site? And what's at the URL seems to be a newer version, which actually has a license statement that specifies GPLv2+. Not sure what's up there, or which to believe. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review