https://bugzilla.redhat.com/show_bug.cgi?id=1881482 --- Comment #5 from Andrey Matyukov <andrey.matyukov@xxxxxxxxx> --- Thanks for the review, Petr. I've updated SPEC/SRPM and fixed most of your findings. As to the URL, you are right, it has to point to the tagged commit, so now it points to the latest release, which was out recently and contains all required changes. The only thing that might look unusual for you is the reference to the doc in the description, that points to the doc located deep inside the source tree under %{url}. This is the constraint of the github project organization: the crypto_mb library, that is going to be upstream-ed, now is hosted within the project for another library IPP Crypto, which is not target for upstreaming. So, that's why URL contains github home for the hosted project, and the doc refers to the inner one. Please take a look at it again and let me know if it now looks ok. The links to updated spec/srpm are in the BZ description. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
