https://bugzilla.redhat.com/show_bug.cgi?id=1885495 --- Comment #14 from Carl George 🤠 <carl@xxxxxxxxxx> --- The review tool only works with an overall successful copr build. Go ahead and disable the targets that failed so we can get a clean build. I suggest waiting for the final SRPM out of bug 1885430 (qatlib review) because it's very close to being finished. You'll also need to duplicate the same ExcludeArch directive they are using, with a comment explaining that it must match qatlib's ExcludeArch. ExcludeArch: %{arm} aarch64 %{power64} s390x > Please review the SPEC file and let us know if anything needs to be corrected. Minor tweak, in the %files section you probably want to consistently use your %{soversion} macro by making this change: %{_libdir}/libqatengine.so.%{soversion}.%{version} -%{_libdir}/libqatengine.so.0 +%{_libdir}/libqatengine.so.%{soversion} %{enginesdir}/qatengine.so Otherwise you risk forgetting to change that 0 when the soversion definition eventually changes. > - We will take care of removing the ./autogen.sh script and include 'autoreconf -vif' in next release into github. I'll continue the review once this is done, in a successful copr build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
