[Bug 1885430] Review Request: qatlib - Intel® QuickAssist Technology Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1885430



--- Comment #16 from Carl George 🤠 <carl@xxxxxxxxxx> ---
Awesome, thanks for doing the work to get that debundled and add the makefile
target.  Importing the latest version of the spec file into dist-git is fine. 
However, in the latest version of the spec file you made an extra change that
needs to be reverted before it's imported.

-%{_libdir}/libqat.so.%{soversion}.%{version}
-%{_libdir}/libusdm.so.%{soversion}.%{version}
-%{_libdir}/libqat.so.%{soversion}
-%{_libdir}/libusdm.so.%{soversion}
+%{_libdir}/libqat.so.*
+%{_libdir}/libusdm.so.*

When listing shared library files, they should not be listed with a glob that
conceals the soname version [0].


[0]
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux